docker: Fix some incomlpete types in docker #14817
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
requested changes
Oct 7, 2025
Comment on lines
+13
to
14
| # TODO: handle requires the type pywin32._win32typing.PyHANDLE | ||
| def __init__(self, handle=None) -> None: ... |
There was a problem hiding this comment.
Another workaround is to add a type alias like this above and use that here:
_PyHANDLE: TypeAlias = Any # TODO: pywin32._win32typing.PyHANDLE
Comment on lines
+21
to
+22
| # TODO: return type requires the type pywin32._win32typing.PyHANDLE | ||
| def detach(self) -> Incomplete | None: ... |
| def check_resource(resource_name: str): ... | ||
| def minimum_version(version: str): ... | ||
| def update_headers(f: Callable[..., Incomplete]): ... | ||
| def update_headers(f: Callable[..., Any]): ... |
There was a problem hiding this comment.
Considering that this is a decorator, we should either use type var and use the same type var for the returned callable, or just leave it as Incomplete for now.
| def parse_devices(devices: Iterable[str | dict[str, Incomplete]]) -> list[dict[str, Incomplete]]: ... | ||
| def kwargs_from_env(environment: Mapping[str, Incomplete] | None = None) -> _EnvKWArgs: ... | ||
| def parse_devices(devices: Iterable[str | dict[str, str]]) -> list[dict[str, str]]: ... | ||
| def kwargs_from_env(environment: Mapping[str, AnyStr] | None = None) -> _EnvKWArgs: ... |
There was a problem hiding this comment.
AnyStr is a type var and as such needs a second use. You probably just want to use str | bytes here.
| def GetOverlappedResult(hFile: int, overlapped: _win32typing.PyOVERLAPPED, bWait: int | bool, /) -> int: ... | ||
| def WaitNamedPipe(pipeName: str, timeout, /) -> None: ... | ||
| def GetNamedPipeInfo(hNamedPipe: int, /) -> tuple[Incomplete, Incomplete, Incomplete, Incomplete]: ... | ||
| def GetNamedPipeInfo(hNamedPipe: int, /) -> tuple[int, int, int, int]: ... |
There was a problem hiding this comment.
Could we move this change to a separate PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't do all of them but this is hopefully a nice start :)